Attachment 254314 Details for Bug 282164 – audio/oss: fix build with clang 19

[patch] audio/oss: fix build with clang 19

audio__oss-fix-clang19-build-1.diff (text/plain), 1.55 KB, created by Dimitry Andric on 2024-10-17 19:22:27 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dimitry Andric

Created: 2024-10-17 19:22:27 UTC

Size: 1.55 KB

patch

obsolete

>commit eb8728019bb40cdb1e83243fdefbeb56e2f1bfcd
>Author: Dimitry Andric <dim@FreeBSD.org>
>Date:   2024-10-17T15:14:26+02:00
>
>    audio/oss: fix build with clang 19
>    
>    Clang 19 has become more strict about erroneous redeclarations, which
>    results in an error building audio/oss:
>    
>      oss_sndstat.c:114:17: error: redeclaration of 'version' with a different type: 'char[]' vs 'const char[]'
>        114 |     extern char version[];
>            |                 ^
>      /usr/include/sys/systm.h:54:19: note: previous declaration is here
>         54 | extern const char version[];    /* system version */
>            |                   ^
>    
>    Since version[] has been a const char for quite a while now, adjust the
>    redeclaration in oss_sndstat.c. Note that it also might be deleted
>    entirely, since the file already includes <sys/systm.h>.
>    
>    PR:             282164
>    MFH:            2024Q4
>
>diff --git a/audio/oss/files/patch-kernel_framework_sndstat_oss__sndstat.c b/audio/oss/files/patch-kernel_framework_sndstat_oss__sndstat.c
>new file mode 100644
>index 000000000000..8a565c3a61a1
>--- /dev/null
>+++ b/audio/oss/files/patch-kernel_framework_sndstat_oss__sndstat.c
>@@ -0,0 +1,11 @@
>+--- kernel/framework/sndstat/oss_sndstat.c.orig	2024-10-17 08:20:46 UTC
>++++ kernel/framework/sndstat/oss_sndstat.c
>+@@ -111,7 +111,7 @@ init_status (void)
>+ #if defined(__FreeBSD__) || defined(__OpenBSD__) || defined(__NetBSD__)
>+   {
>+ #if defined(__FreeBSD__)
>+-    extern char version[];
>++    extern const char version[];
>+ #endif
>+ 
>+     put_status ("Kernel: ");

Actions: View | Diff

Attachments on bug 282164: 254314